Adding null check before clearing mouseDownTimeout#201
Open
nzayatz14 wants to merge 2 commits intoreact-component:masterfrom
Open
Adding null check before clearing mouseDownTimeout#201nzayatz14 wants to merge 2 commits intoreact-component:masterfrom
nzayatz14 wants to merge 2 commits intoreact-component:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #201 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 10 10
Lines 484 484
Branches 121 122 +1
=======================================
Hits 427 427
Misses 57 57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I was also running into perf issue caused by the same code when unmounting 10k+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I was recently doing some performance testing on a virtual table component I had written. With rows constantly unmounting & remounting, I wanted to make sure the scroll was still smooth with tooltips (rc-tooltips to be exact).
During my tests, I noticed that a significant amount of my table cells needed to clear a timeout upon unmounting of the row, this caused lag in my scrolling.
I found the call was made by rc-trigger in it's
componentWillUnmountfunction. I added a simple null-check before theclearTimeoutfunction and it significantly improved my scrolling performance.I also noticed that the other timer,
this.delayTimer, has its own function that handles this case ->this.clearDelayTimer()and was wondering whythis.mouseDownTimeoutdid not have something similar.Thanks!
Nick